KFFI/contest_template
Template
Watch
6
0
Fork
You've already forked contest_template
 0
Code Issues Pull requests 2 Projects Releases Packages Wiki Activity Actions 1

Add bits/stdc++.h replacement helper and support generator.sh #4

Open
haire wants to merge 1 commit from haire/fix_check_problems into main AGit
pull from: haire/fix_check_problems
merge into: KFFI:main
Conversation 1 Commits 1 Files changed 3 +390 -6
haire commented 2026-08-22 15:18:14 +00:00
Member
Copy link

check_problem.sh now accepts generator.sh (nicer than generator, since editors highlight .sh), and the bits/stdc++.h failure now points at a new helper, scripts/bits-replacer.py, that rewrites the include into the minimal real headers. CI policy is unchanged: bits/stdc++.h still fails the check.

Also fixes the source-file scan to include .cxx/.c++/.h++, which were silently skipped before.

The helper is a manual, opt-in tool, not run at compile time or by CI, vendored from hairez/bits-replacer.

`check_problem.sh` now accepts `generator.sh` (nicer than generator, since editors highlight `.sh`), and the `bits/stdc++.h` failure now points at a new helper, `scripts/bits-replacer.py`, that rewrites the include into the minimal real headers. CI policy is unchanged: `bits/stdc++.h` still fails the check. Also fixes the source-file scan to include `.cxx/.c++/.h++`, which were silently skipped before. The helper is a manual, opt-in tool, not run at compile time or by CI, vendored from `hairez/bits-replacer`.
Add bits-replacer tool and fix check_problem.sh
Some checks are pending
CI / Code Quality (pull_request) Blocked by required conditions
Details
CI / Get Problem Changes (pull_request) Blocked by required conditions
Details
CI / Python (pull_request) Blocked by required conditions
Details
CI / Shell Scripts (pull_request) Blocked by required conditions
Details
CI / Get changed problems (pull_request) Blocked by required conditions
Details
0541821c41
tagl reviewed 2026-08-25 14:59:57 +00:00
.ruff.toml
@ -4,3 +4,3 @@
output-format = "grouped"
target-version = "py310"
extend-exclude = ["./testdata_tools/", "problems/*/submissions/*/deepseek_*.py", "problems/*/submissions/*/openai_*.py"]
extend-exclude = ["./testdata_tools/", "./scripts/bits-replacer.py", "problems/*/submissions/*/deepseek_*.py", "problems/*/submissions/*/openai_*.py"]
tagl commented 2026-08-25 14:53:46 +00:00
Owner
Copy link

Why is the script added as an exception?

Why is the script added as an exception?
scripts/bits-replacer.py
@ -0,0 +158,4 @@
# A stable, roughly canonical ordering for emitted includes (C then C++ containers
# then algorithms then I/O), falling back to alphabetical for anything unlisted.
ORDER = [
tagl commented 2026-08-25 14:58:42 +00:00
Owner
Copy link

Why not just alphabetical over all?

Why not just alphabetical over all?
haire commented 2026-08-26 13:19:58 +00:00
Author
Member
Copy link

That is simpler. Committed upstream in github.com/hairez/bits-replacer@d677428aed

That is simpler. Committed upstream in https://github.com/hairez/bits-replacer/commit/d677428aed527972a23e58455f099c637a5c8915
scripts/check_problem.sh
@ -32,0 +33,4 @@
if [ -x generator.sh ]; then
gen=(./generator.sh)
elif [ -f generator.sh ]; then
gen=(bash generator.sh)
tagl commented 2026-08-25 14:59:37 +00:00
Owner
Copy link

Generator should be executable, this should be an error in my opinion

Generator should be executable, this should be an error in my opinion
scripts/check_problem.sh
@ -32,0 +35,4 @@
elif [ -f generator.sh ]; then
gen=(bash generator.sh)
else
gen=(./generator)
tagl commented 2026-08-25 14:59:24 +00:00
Owner
Copy link

I think it's fair to emit a warning here as having the extension is nicer.

I think it's fair to emit a warning here as having the extension is nicer.
Some checks are pending
CI / Code Quality (pull_request) Blocked by required conditions
Details
CI / Get Problem Changes (pull_request) Blocked by required conditions
Details
CI / Python (pull_request) Blocked by required conditions
Details
CI / Shell Scripts (pull_request) Blocked by required conditions
Details
CI / Get changed problems (pull_request) Blocked by required conditions
Details
This pull request can be merged automatically.
Some workflows are waiting to be reviewed.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin +refs/pull/4/head:haire/fix_check_problems
git switch haire/fix_check_problems

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main
git merge --no-ff haire/fix_check_problems
git switch haire/fix_check_problems
git rebase main
git switch main
git merge --ff-only haire/fix_check_problems
git switch haire/fix_check_problems
git rebase main
git switch main
git merge --no-ff haire/fix_check_problems
git switch main
git merge --squash haire/fix_check_problems
git switch main
git merge --ff-only haire/fix_check_problems
git switch main
git merge haire/fix_check_problems
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
tagl
matistjati
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
KFFI/contest_template!4
No description provided.